test(core): enforce transport exact optional compatibility#1767
Open
rechedev9 wants to merge 2 commits intomodelcontextprotocol:fweinberger/transport-exact-optional-typesfrom
Open
Conversation
|
| Name | Type |
|---|---|
| @modelcontextprotocol/core | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
9 tasks
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exactOptionalPropertyTypescompile check for the Transport compatibility case@modelcontextprotocol/core's existingtypecheckscriptcreateFetchWithInitRequestInit.headersassignment that fails once exact optional property types are actually enforcedWhy
PR #1766 fixes the public type surface, but without compiling a targeted check under
exactOptionalPropertyTypes: truethe regression can still slip back in. When that check is enabled,createFetchWithInitalso needs a small adjustment because assigningheaders: undefinedintoRequestInitis rejected under exact optional property semantics.Verification
pnpm --filter @modelcontextprotocol/core typecheckpnpm --filter @modelcontextprotocol/core test -- transport.types.test.tspnpm --filter @modelcontextprotocol/core lint